fix: use :modal pseudo-class so only showModal() dialogs get modal styles - #73
Open
54145a wants to merge 1 commit into
Open
fix: use :modal pseudo-class so only showModal() dialogs get modal styles#7354145a wants to merge 1 commit into
54145a wants to merge 1 commit into
Conversation
…yles PicoCSS applies modal overlay styles (fixed position, fullscreen backdrop, z-index, centering) to ALL <dialog> elements, regardless of how they are opened. This is incorrect — only dialogs opened with showModal() should receive modal styles. Dialogs opened with show() should behave as non-modal popovers without the fullscreen backdrop or scroll-lock. Added :modal pseudo-class to the core dialog selector so modal styles only apply when the dialog is actually in the modal state. This is not a breaking change since no one uses show() to display a modal dialog. The original author even recommends toggling the open attribute, which MDN states is not the intended usage. This also blocks the Popover API. Ref: picocss#586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PicoCSS applies modal overlay styles (fixed position, fullscreen backdrop, z-index, centering) to ALL elements, regardless of how they are opened. This is incorrect — only dialogs opened with showModal() should receive modal styles. Dialogs opened with show() should behave as non-modal popovers without the fullscreen backdrop or scroll-lock.
Added :modal pseudo-class to the core dialog selector so modal styles only apply when the dialog is actually in the modal state. This is not a breaking change since no one uses show() to display a modal dialog.
The original author even recommends toggling the open attribute, which MDN states is not the intended usage. This also blocks the Popover API.
Ref: picocss#586