[Zaimwa9]

What

Delta re-reviews now run on draft PRs that already carry a themis review. First reviews still skip drafts, unchanged.

Why

Draft status gated every automatic trigger, so a draft with an existing review never re-reviewed the commits that answered its findings. Observed on Flagsmith/flagsmith-cli#43: a maintainer iterating on 12 open bot threads pushed fix after fix, and nothing re-checked them — the threads stayed open and delta never fired once.

Reviewing a draft and iterating before marking it ready is the normal way to work; on some teams it is the only way PRs get reviewed. For them delta_review: true was unreachable — they had opted into a feature that could never trigger.

The consent argument is #103's, one step further. auto_review asks "review PRs nobody asked about?"; draft asks "is this ready to be looked at?". A draft carrying a themis review has already been looked at, deliberately (on a draft, a first review can only come from an explicit mention). The pushes that follow are answers to those findings.

How

One condition: the draft skip applies to first reviews only.

if pr.get("state") != "open" or (auto and not delta and pr.get("draft")):

Nothing else needed to stay safe — a push to a never-reviewed draft still gets nothing, because _resolve_delta_base returns None when no checkpoint exists and the run exits before any engine starts. So this cannot turn drafts into first-review noise, and delta_review remains the switch.

Tests

• draft + push + prior review + delta_review → deltas (was: skipped entirely)
• draft + push + no prior review → nothing (the important guard)
• draft + push + delta_review: false → nothing
• draft + PR opened → still skipped, and draft + explicit mention → still runs (both unchanged)

Docs updated; the delta section previously stated the old rule.

[themis-lezgo]

🟠 Major · ⚡ Quick win

Draft delta re-reviews never enter the pipeline.

Observed: _parse_pull_request in src/themis/events.py returns None for every payload whose PR is a draft, before it creates the ReviewJob that carries delta=True; the existing parser regression test asserts this exact outcome for draft synchronize events. Predicted: a push to a draft with a valid prior Themis checkpoint would still be ignored, so this documented behavior would not occur.

Allow draft synchronize events through the parser while continuing to skip draft opened and ready_for_review events, and add the parser-level regression test.

[themis-lezgo]

⚖️ Themis review: 🟠 Fix before merge

This change updates the service-level draft guard, but draft push events are still discarded at the webhook parsing boundary, so the promised delta re-reviews cannot run. CI is still running.

🎯 Correctness	2/5
🧪 Test coverage	2/5
📐 Code quality	3/5
🚀 Product impact	2/5

🟠 Majors

• docs/configuration.md:194 — draft delta re-reviews remain unreachable from pull_request webhooks.

📝 Walkthrough

• Draft delta eligibility - permits delta=True jobs through the review-service draft guard while preserving the first-review draft skip.
• Webhook ingress - still rejects every draft pull_request event before a delta job is created.
• Documentation - describes draft delta re-reviews as enabled, though the ingress path prevents them.

🧪 How to verify

1. Run uv run pytest -q tests/test_events.py tests/test_review_service.py.
2. Verify a draft pull_request.synchronize payload creates ReviewJob(..., auto=True, delta=True) while draft opened and ready_for_review payloads remain skipped.
3. With triggers.delta_review: true and a signed prior checkpoint, push a commit to a draft PR and confirm a delta summary is posted.
   Automate: retain a parser-level regression test for the draft synchronize exception alongside the service-level delta test.

Product take: This is a solid workflow improvement for teams that review drafts, but it currently has no effect for webhook-driven deployments because the event never enters the review pipeline.

🧭 Assumptions & unverified claims

No unverified assumptions or claims.

The delta engine has the green light, but the webhook bouncer is still checking drafts off the list. · reviewed at 7e96dc1