Repository navigation
Upgrade the apps that own database tables - #256
Merged
Merged
Conversation
allauth, DRF and django-celery-beat are the third-party apps with tables in our database, so their migrations decide whether an upgrade touches the schema. None of them adds a migration. DRF's and celery-beat's migration files are byte-identical to the current versions. allauth keeps the same migration names; its edits to old migrations are style and multi-database fixes to two data migrations that production already ran. makemigrations and migrate --plan both report nothing to do. djangorestframework-stubs moves to 3.18 alongside DRF, as held back earlier. Assistant-model: Claude Code
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of the dependency upgrades: the three third-party apps with tables in our database. None of them changes the schema.
djangorestframework-stubs moves to 3.18.1 with DRF, as held back in #251.
allauth's edited migrations
Five of allauth's existing migration files changed between versions. I diffed each one:
account/0001,0002andsocialaccount/0001:unique_together=set([...])→{...}. Style only.account/0006and0008: data migrations now call.using(db_alias), so they work with multiple databases. Production applied both long ago, so they won't run again.Verified
makemigrations --check(all apps) andmigrate --planon an existing database: nothing to do.manage.py check: no issues.Heads-up for the Django step
django-celery-beat 2.9.0, the latest release, requires
Django<6.1. Django 6.0 works, but 6.1 waits on a new celery-beat release.