[Fivell]

Found while writing the first test suite (#9). Branched off that PR, because the specs need its harness.

This is the twin of the bug #9 fixes, eight lines into the hot path.

The bug

$('body').append('<div class="block_timerange">…</div>').ready(function () {
  // every preset handler is bound in here
});

On jQuery 1 and 2 .ready() on an already-ready document ran synchronously via .done(). jQuery 3 rebuilt it on a Deferred (jQuery.fn.ready = function (fn) { readyList.then(fn) }), and Deferred.then schedules through window.setTimeout. So:

• the popup is on screen but inert for a macrotask after every open;
• two quick clicks resolve both deferred callbacks against the single surviving popup and double-bind every handler;
• .ready() on a non-document collection is deprecated in jQuery 3 and removed in jQuery 4 — there the popup would never bind at all, which is exactly the failure mode Add a dummy app, specs and CI; fix form auto-init on jQuery 3 #9 exists to fix.

The fix

Nothing here waits for anything: append is synchronous and the nodes exist on the next line. Bind straight away.

The spec

Clicks "Set range" and a preset inside a single execute_script, so both land in the same tick. On the parent commit the preset click hits an unbound popup and the input stays empty.

[Copilot]

Copilot review overview

🟢 Approval recommended

The focused implementation correctly removes deferred binding and includes regression coverage for both affected interactions.

Review effort: Balanced
Findings: None

What changed in this PR

Binds popup handlers synchronously, preventing inert or duplicate-bound preset popups across jQuery versions.

Changes:

• Appends the popup and immediately registers its handlers.
• Adds regression tests for same-tick preset selection and dismissal.

File	Description
vendor/​assets/​javascripts/​active_admin_date_range_preset.js	Replaces deferred .ready() binding with immediate binding.
spec/​popup_binding_spec.rb	Tests synchronous popup interactions.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.