Repository navigation
v2.0.2 Qualifying lap-completion timing and qualifying sector timing fixes - #93
Merged
Merged
Conversation
Qualifying knockout greying: - Derive each driver's reached segment from results Q1/Q2/Q3 columns and flag knocked_out per replay frame once a later segment begins; drivers keep their position and posted time and are dimmed in the leaderboard. - Live: KnockedOut now sets a knocked_out flag instead of retired, so eliminated drivers stay visible and dimmed rather than dropping out. Qualifying lap-completion bubbles: - New top-of-track bubble per completed flying lap showing initials, lap time (timing-tower colour), and sector markers. Toggleable in Settings -> Leaderboard (qualifying only), default on. - Extract the leaderboard's last-lap colour logic and sector squares into a shared lib/lapTiming module so the tower and bubble share one source. Requires recompute for historical qualifying sessions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Sector indicators in qualifying trailed lap completion by ~4s because they were timed with the Q1 green-flag offset (used for the phase countdown) instead of the telemetry-aligned offset that lap times use. Time the sector block with min_date - t0_date so markers appear exactly when the car crosses the line, in sync with the last-lap time. Scoped to the sector block only; session_time_offset/countdown/gaps are untouched. Requires recompute for historical qualifying sessions. - Delay the lap notification bubble by 0.5s so it appears just after the car crosses the line rather than just before. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
npm audit fix updated next 15.5.14 -> 15.5.19, resolving both high-severity advisories and one moderate. Remaining 2 moderate (postcss CSS-stringify XSS, bundled in next) require a breaking major change and are not applicable to a static export with no untrusted CSS input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Implement qualifying knockout greying and lap-completion bubbles
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualifying lap notifications — as each driver crosses the line in qualifying, a bubble appears at the top of the track map showing their lap time and sector markers. Toggleable in Settings>Leaderboard.
Knocked-out drivers in qualifying — drivers eliminated in Q1/Q2 are now greyed out once the next session begins, instead of continuing to display as active. Drivers keep their position and the lap time they posted. Applies to both replay and live timing. Requires re-compute for historical qualifying sessions.
Fixes