Repository navigation
Update Datadog guides for the reworked upstream example - #1481
Conversation
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Deploying agentproxy with
|
| Latest commit: |
c669ce1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdfb85b8.agentproxy.pages.dev |
| Branch Preview URL: | https://kkb-datadog-example-sync.agentproxy.pages.dev |
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
| To reuse an existing Gateway, remove the Gateway definition from | ||
| `gateway.yaml` and update the other files to refer to your Gateway. |
There was a problem hiding this comment.
maybe specify the files
| To reuse an existing Gateway, remove the Gateway definition from | |
| `gateway.yaml` and update the other files to refer to your Gateway. | |
| To reuse an existing Gateway, remove the Gateway definition from `gateway.yaml`. Then update the HTTPRoute and AgentgatewayPolicy in that file to refer to your Gateway. Add `spec.infrastructure.parametersRef` to your Gateway that points to the `datadog-observability` AgentgatewayParameters. Without this reference, the proxy has no Datadog annotation and the Agent does not collect proxy metrics. | |
There was a problem hiding this comment.
Done in 41cb58a. I used your wording, which names the HTTPRoute and AgentgatewayPolicy in gateway.yaml and the parametersRef to datadog-observability.
| The proxy check in `proxy-parameters.yaml` sets `use_latest_spec: true` so | ||
| that the Agent parses the proxy's output as OpenMetrics. Without this | ||
| setting, the Agent drops every counter. The controller | ||
| check in `controller-annotations.yaml` sets `use_latest_spec: false`, because | ||
| the controller serves the classic Prometheus text format. |
There was a problem hiding this comment.
This is in the troubleshooting, too, maybe remove it to avoid duplication in one of the places.
There was a problem hiding this comment.
Good catch. I removed the use_latest_spec paragraph from step 3 in 41cb58a and kept it in Troubleshooting, under "Gauges appear but counters are missing", where it has the fuller explanation.
| To match your deployment, adjust the port and backend addresses. | ||
|
|
||
| ```yaml | ||
| # yaml-language-server: $schema=https://agentgateway.dev/schema/config |
There was a problem hiding this comment.
Why is this not using the shortcode? same in L177
| # yaml-language-server: $schema=https://agentgateway.dev/schema/config | |
| # yaml-language-server: $schema=`{{< reuse "agw-docs/snippets/schema.md" >}}` |
There was a problem hiding this comment.
Switched both lines (95 and 177) back to the schema.md reuse shortcode in c669ce1. I left out the backticks, because inside the code fence they would render literally, and to match the other pages that use this snippet.
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Updates the Datadog guides for the reworked upstream example in agentgateway/agentgateway#3935, which ships in 1.7.
The guides told readers to run files that #3935 removed:
smoke.sh,smoke.py,compose.datadog.yaml,proxy-values.yaml, andcontroller-values.yaml. They also described an OpenTelemetry Collector the example no longer uses. The example now configures an existing agentgateway installation, uses the HomeHub demo model, and sends traces directly to the Datadog Agent.Changes
Both
datadog.md(Kubernetes) anddatadog-standalone.md:examples/datadogonmain.use_latest_spec. The proxy check usestrue, because without it the Agent parses the proxy's OpenMetrics output as classic Prometheus text and drops every counter. The controller check usesfalse, because the controller serves classic Prometheus text.Kubernetes only:
agentgateway-systemin commands.Standalone only:
config.yamlfragment to merge, and notes that the controller widgets stay empty in standalone mode.The direct trace export sections are unchanged.
Testing
Ran against agentgateway v1.7.0 with the upstream example at
main, using a placeholder Datadog API key.agentgateway_requests_totalandagentgateway_gen_ai_client_token_usage.agent check openmetrics --check-rate --discovery-min-instances 2found both instances, taggedcomponent:proxyandcomponent:controller, and producedagentgateway.requests.count,agentgateway.gen_ai.token.usage.sum, andagentgateway.controller.reconciliations.count.config.yamlfragment matches upstream and passes--validate-only. Ran steps 1–8 with the same request and metric results. Theopenmetricscheck reported samples taggedcomponent:proxy.openmetricscheck with and withoutuse_latest_specagainst the proxy and controller, and validated the standalone config on v1.6.0.latest, andmainfor both deployment types, with no references to the removed files.datadog-traces-schemaanddatadog-schema. The remaining CI failures are in files this PR doesn't change (expose-ui.md,dataplane.mdgates, and anmcp-authzlink).Not tested, because they need a real Datadog organization: steps 9–10 (Metrics Explorer and the dashboard import) and trace ingestion into Agent Observability. The trace screenshots in
datadog-verify.mdstill show the old example's synthetic model and aren't updated in this PR.🤖 Generated with Claude Code