Feat: integrate batch allocator in processor allocator - #4559
lacroixthomas wants to merge 21 commits into
Conversation
|
Build Failed 😭 Build Id: c114e430-ff0d-4839-957e-5fd66102b7b0 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
1 similar comment
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This is quite a "direct" import of the changes from the original PR, did minor updates on it |
|
Build Failed 😭 Build Id: c50b1a31-0600-48c2-95e8-4face7902b8e Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: 4246cd2b-53d1-4624-98df-3b0ca5e6fb97 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: ff1ca275-3f67-4710-8594-a3dcf6bd472f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 68ed4e65-1fa3-402d-8035-3e561058d925 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: d8e3da64-c889-4a5f-a488-91c6d963bd23 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
LGTM! |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: 49b84f77-5e45-46f3-b9bf-5e7a10dc66a9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: 551a05f8-1a19-4098-9389-1bd9d8fad35f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
fd67e32 to
8bf3c39
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: d52a066c-5aed-45fc-a35e-f207dca8a47b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 2f1cd500-b351-4a80-88f2-a0963b5a53c1 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
1 similar comment
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
I'll need to double check all the feedbacks, but there might just be the unit tests left to do ! 🤞🏼 |
|
Build Failed 😭 Build Id: 50072e00-42a2-4d52-9bff-925483b45081 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
2094827 to
5159f5d
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: 03b083d4-96c5-41b4-87b1-75c57b04822d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Spotted an issue with counter and list that currently silently fails allocations if they don't fit, working on a fix |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
Build Succeeded 🥳 Build Id: 30aebe03-d344-49ab-940d-ae8e956f1155 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Failed 😭 Build Id: 702698ea-49c0-4975-82de-0ad86226473b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: 5f648490-8a73-436f-b553-721c06a1c33b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This pipeline was using the ProcessorAllocator as Alpha - for testing purpose |
|
Build Failed 😭 Build Id: b3e59bdd-2d0e-488d-91fc-548d76974c1d Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: fc558b37-2b6b-4542-bc46-979174b39d32 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Bring the batch allocator improvement from this PR to the processorAllocator feature gate : #4176
Which issue(s) this PR fixes:
Part of #4190 and #3992
Special notes for your reviewer: