Skip to content

feat: use new errors pkg in pkg/util/* - #4716

Merged
lacroixthomas merged 3 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-in-util-pkg
Sep 15, 2026
Merged

lacroixthomas merged 3 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-in-util-pkg

Conversation

@lacroixthomas

Copy link
Copy Markdown
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/util/* files

Which issue(s) this PR fixes:
Work on #4510

Did you use AI tools in preparing this PR?:
Y

Special notes for your reviewer:

@github-actions github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/M labels Sep 3, 2026
@lacroixthomas
lacroixthomas marked this pull request as ready for review September 4, 2026 00:00
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 7c888b0a-09e2-46ca-ad4e-e4138bcb0c29

Status: INTERNAL_ERROR

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
lacroixthomas requested a review from a team September 6, 2026 22:05
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 09ec736e-a577-491c-8e1a-1b728d90504a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4716/head:pr_4716 && git checkout pr_4716
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-039eb9d

@markmandel

Copy link
Copy Markdown
Member

Can fix conflicts plz

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@lacroixthomas
lacroixthomas force-pushed the features/integrate-errors-in-util-pkg branch from 039eb9d to 6c6c8b2 Compare September 14, 2026 19:57
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 2704aeeb-4b29-4f50-b01d-1d5b35a932b5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4716/head:pr_4716 && git checkout pr_4716
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-6c6c8b2

@markmandel markmandel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit that I don't think is worth blocking on - change if you think you should 👍🏻

Comment thread pkg/util/httpserver/httpserver.go Outdated
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@lacroixthomas
lacroixthomas enabled auto-merge (squash) September 15, 2026 12:41
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: c2462ccf-16b3-4267-a035-d693d1844e34

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas

Copy link
Copy Markdown
Collaborator Author

Build Failed 😭

Build Id: c2462ccf-16b3-4267-a035-d693d1844e34

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

http://cmake.org/ still down - Shall see we we want to skip it or if they fix it soon

@lacroixthomas

Copy link
Copy Markdown
Collaborator Author

/gcbrun

1 similar comment
@lacroixthomas

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 2819a24f-5298-40dd-81ba-1b3427aed918

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

Copy link
Copy Markdown
Member

/gcbrun

@markmandel

Copy link
Copy Markdown
Member

if this fails again, let's just ignore it.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 301441a7-ea96-41fb-b078-271f100a63ad

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4716/head:pr_4716 && git checkout pr_4716
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-30bbbde

@lacroixthomas
lacroixthomas merged commit 3efd523 into agones-dev:main Sep 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants