Conversation
vitalivo
force-pushed
the
fix/pep604-class-unions
branch
from
September 13, 2026 16:23
469237e to
97ef4ea
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use the union checker for PEP 604 unions inside
type[...], as already done fortyping.Union.For example,
check_type(list, type[str | Any])currently raisesTypeCheckError, even thoughAnypermits the class. Invalid classes also lose the per-member diagnostics. The regression tests cover both positions ofAny, accepted classes, and rejection messages for both union spellings.Validation
typeshed.stdlib.typesimport in_decorators.py:22on the base commit and this patch.Checklist