Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
check_type(frozenset({1}), set[int])currently passes because concrete sets use the same instance check asAbstractSet. Dictionary key views are also accepted, although neither provides the mutablesetAPI.Require a
setinstance for concrete set annotations. Keep accepting set subclasses, and preserve the broader behavior ofAbstractSet. Tests cover built-in andtypingannotations, empty/nonempty frozen sets, key views, and subclass controls.Validation: full tox suite on Python 3.10–3.15, pre-commit and package checks passed. The strict docs build has the same two
typing.Unioncross-reference warnings as unmodified master.Checklist