Repository navigation
Conversation
Signed-off-by: Harry Lee <harrli@nvidia.com> (cherry picked from commit 094aaca) Signed-off-by: Harry Lee <harrli@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport merged #15631 to
release/1.6.0so the release can expose the native routing interfaces required by AISimulate #306. The inspected release branch predatesSessionAffinity::with_manual_clock; publishing it unchanged would not provide the API that AISimulate uses.This is an unmodified
cherry-pick -xof094aaca91941421bb0dcb645b0f700a42d6de3ef, with no new routing design. AISimulate still owns AgentX simulation and calls Dynamo's production policy. Dynamo #15240 remains optional compatibility cleanup.Details
The backport preserves #15631's host-controlled affinity clock, shared group-key helper, and queue capacity-recheck entry point, together with its original callers/tests. It does not publish packages or change release automation.
AISimulate's release-artifact check currently fails because the required native policy packages are absent from crates.io. The registry dependency closure at 1.6.0 is
dynamo-tokens,dynamo-kv-hashing,dynamo-truthy,dynamo-runtime,dynamo-kv-router, anddynamo-custom-policy-builtin; Cargo must resolve optional registry dependencies when packaging too. After this backport is accepted, the matching packages still need the normal Dynamo release/DevOps staging and promotion process. Merging this PR alone does not unblock AISimulate's artifact check.Validation
04720e4d.NoopSequencePublisher(AISimulate commit6f0cdd2d43ece4496b1267e7c8095fd1d007df26), avoiding the main-onlyLocalWorkerLoadcallback signature. Its 42 targeted native-router tests pass with the existing main pin.cargo check --offline --lib --features native-dynamo-routerwith its actual native dependency graph redirected to this release/backport source. The production Git pin and lockfile were not changed. No additional metrics backport is required.Where should the reviewer start?
Compare the patch with #15631, then review
lib/kv-router/src/services/selection/affinity.rsandlib/kv-router/src/scheduling/policy_queue.rsagainst the release branch. Verify that the release source and promoted crate versions contain these APIs together.Related Issues
Relates to AIC-1817, original #15631, and AISimulate #306.