Repository navigation
feat: custom executable locations for every agent harness - #223
Open
hongkongkiwi wants to merge 1 commit into
Open
hongkongkiwi wants to merge 1 commit into
hongkongkiwi wants to merge 1 commit into
Conversation
hongkongkiwi
force-pushed
the
provider-executable-overrides
branch
5 times, most recently
from
November 1, 2026 04:45
dd55732 to
d351ee2
Compare
hongkongkiwi
force-pushed
the
provider-executable-overrides
branch
from
November 1, 2026 04:56
d351ee2 to
f40ae6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes #220
Settings → Providers offered an executable location override for 16 agents, but the three first-party harnesses (Claude Code, Codex, Kimi Code) had no card and no override, so a CLI outside the standard locations could not be pointed at. This change:
validated_executableinprovider_settings.rsnow accepts every provider inproviders::PROVIDERS(via the sameknown_providercheck the per-provider environment variables already use) instead of a duplicated 16-id literal, so the gate cannot drift when harnesses are added.provider_set_executableIPC.docs/providers.mddrops the "harnesses without a card" sentence,docs/settings.mdno longer says executable paths are limited to OpenCode or Antigravity, and the warm-adoption list inAGENTS.mdgains the executable.How it was tested
npx tsc --noEmit— clean.cargo test --manifest-path src-tauri/Cargo.toml --libfilters:provider_settings19 passed (includes the updated allowlist test),warm4 passed,connections5 passed.PW_PORT=1439 npx playwright test tests/provider-settings.spec.ts tests/grok.spec.ts— 42 passed in Chrome: hydration of the three new forms, save round-trip, and the preview grouping test.npm test— 201 passed; the 4 failures are pre-existing on unmodified main (3 bundle tests need a priornpm run build, which a fresh worktree has not run; 1 tool-cards date-format test fails on main too).provider-settings.tsis a lazy-loaded chunk, so the entry startup budget is untouched.WebKit run is left to CI.
npm run build(typecheck + bundle)npm testcargo test --manifest-path src-tauri/Cargo.toml --lib provider_settings / warm / connections(if Rust changed)Relevant Playwright tests in Chrome (WebKit left to CI)
Checklist
<type>: <description>docs/updated if behavior changedsrc/preview.tsfor new IPC commands (none added; existing mocks cover the unchanged IPC)