Add FunctionParameterAssignment sniff - #117
Merged
Merged
Conversation
Warns when a non-by-reference function/method parameter's value is reassigned within the function body, since callers reading the parameter later would see the last-assigned value instead of the originally passed one. Closes #104
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
============================================
- Coverage 97.74% 97.72% -0.03%
- Complexity 502 513 +11
============================================
Files 29 30 +1
Lines 1465 1493 +28
============================================
+ Hits 1432 1459 +27
- Misses 33 34 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodingStandard.CodeAnalysis.FunctionParameterAssignment, which warns when a function/method parameter not passed by reference is reassigned inside the function body — code reading the parameter afterwards would otherwise see the last-assigned value instead of the original argument.Test plan
vendor/bin/phpunit CodingStandard/Tests/CodeAnalysis/FunctionParameterAssignmentUnitTest.phpvendor/bin/phpunit(full suite, 30/30 passing)Closes #104