Skip to content

Example: Bound upload buffering with streamed chunks - #95

Closed
bthavanish wants to merge 1 commit into
mainfrom
reliability/example-79-upload-streaming
Closed

bthavanish wants to merge 1 commit into
mainfrom
reliability/example-79-upload-streaming

Conversation

@bthavanish

Copy link
Copy Markdown
Collaborator

Purpose

Example source-level improvement for #79. This PR is intentionally a draft and unmerged.

What changed

  • Adds forEachUploadChunk() to stream temporary upload files using a bounded highWaterMark.
  • Awaits each consumer callback so a slow daemon naturally applies backpressure.
  • Ensures the stream is destroyed on completion/error.

Follow-up before merge

Replace the upload handler's memoryStorage() path with disk-backed multipart storage and use this helper for the large-file branch. Add resource-cleanup and concurrent-upload tests.

References #79.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bthavanish bthavanish closed this Aug 29, 2026
@bthavanish bthavanish reopened this Sep 14, 2026
@bthavanish bthavanish closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant