Repository navigation
chore: keep online playback and suggestions to the desktop app - #19
Merged
Merged
Conversation
/api/stream had an env override and /api/recommend had no gate at all, so both could run on a hosted instance. Both now depend only on the desktop launcher's UNSTREAM_DESKTOP. Also shortens the desktop feature list and API table in the READMEs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The READMEs also get a shorter desktop feature list, and the API table loses the two desktop-only playback rows.
.env.exampleanddocs/DESIGN.mddrop the removed setting.Evidence
GET /api/recommendon the hosted site answers 200.After: a new test asserts 404 for GET and HEAD
/api/streamand GET/api/recommendwithUNSTREAM_STREAMING=1and noUNSTREAM_DESKTOP. Full backend suite: 184 passed.Merge Danger
Door: two-way
Blast Radius: self-hosters
A self-hosted server that set
UNSTREAM_STREAMING=trueloses/api/stream. The desktop app setsUNSTREAM_DESKTOP, so it behaves as before.🤖 Generated with Claude Code