Skip to content

bench: byte view rank collisions - #10772

Open
YUZHEthefool wants to merge 2 commits into
apache:mainfrom
YUZHEthefool:bench-byte-view-rank-collisions
Open

bench: byte view rank collisions#10772
YUZHEthefool wants to merge 2 commits into
apache:mainfrom
YUZHEthefool:bench-byte-view-rank-collisions

Conversation

@YUZHEthefool

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

None. This benchmark coverage is split out of #10605 so the optimization can be measured against the same benchmark cases on main.

Rationale for this change

The existing StringView rank benchmarks cover fixed-length inline values and mixed values. These cases add coverage for long values with a sparse external-buffer path, common prefixes, and full 16-byte prefix collisions.

What changes are included in this PR?

  • Add a sparse-long string_view[0-13] case.
  • Add long values with a shared 7-byte prefix, including a nullable case.
  • Add long values with a shared 16-byte prefix, including a nullable case.

This PR contains benchmark coverage only. The implementation change is in #10605.

Are these changes tested?

The benchmark target was run locally with:

cargo bench -p arrow --features test_utils --bench sort_kernel -- "rank string_view"

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Aug 21, 2026
@YUZHEthefool YUZHEthefool changed the title bench byte view rank collisions bench: byte view rank collisions Aug 21, 2026

@Rich-T-kid Rich-T-kid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for splitting the PR @YUZHEthefool! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants