bench: byte view rank collisions - #10772
Open
YUZHEthefool wants to merge 2 commits into
Open
Conversation
Rich-T-kid
approved these changes
Aug 21, 2026
Contributor
There was a problem hiding this comment.
thank you for splitting the PR @YUZHEthefool! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. This benchmark coverage is split out of #10605 so the optimization can be measured against the same benchmark cases on
main.Rationale for this change
The existing
StringViewrank benchmarks cover fixed-length inline values and mixed values. These cases add coverage for long values with a sparse external-buffer path, common prefixes, and full 16-byte prefix collisions.What changes are included in this PR?
string_view[0-13]case.This PR contains benchmark coverage only. The implementation change is in #10605.
Are these changes tested?
The benchmark target was run locally with:
Are there any user-facing changes?
No.