Support map/struct capacities in MutableArrayData - #10801
Merged
Conversation
EmilyMatt
changed the title
Rich-T-kid
approved these changes
Aug 23, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
LGMT, thank you for adding test!
Jefffrey
changed the title
Jefffrey
added
the
enhancement
Jefffrey
approved these changes
Aug 24, 2026
Contributor
|
thanks @EmilyMatt & @Rich-T-kid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests seems to completely skip over this and not even use a MutableArrayData, causing them to pass, but all 3 added tests would panic before adding the Map and Struct cases to the match statement.
With this change we can now use MutableArrayData on maps properly with preallocation(meaning using Capacities::List and Capacities::Struct).
Not actually a breaking change, although it does not panic anymore, which is a change I guess.