Repository navigation
Conversation
Contributor
Author
|
@SteNicholas @FMX @RexXiong Could you kindly help review this PR? Thanks a lot. Any suggestion is welcome. |
SteNicholas
reviewed
Sep 8, 2025
SteNicholas
reviewed
Sep 8, 2025
SteNicholas
left a comment
SteNicholas
left a comment
Member
There was a problem hiding this comment.
Generally looks good to me. I only left the minor comments for this pull request.
Contributor
Author
|
@SteNicholas Thanks for your review, refactored as suggested. Any further suggestion is welcome, thanks a lot. |
FMX
approved these changes
Sep 16, 2025
FMX
left a comment
FMX
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.7.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support PushData network interfaces in cppClient.
Why are the changes needed?
PushData network interfaces are used when writing data to Worker node via cppClient.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.