Skip to content

[CELEBORN-2162] Supress client side connection error logging - #3491

Closed
akpatnam25 wants to merge 4 commits into
apache:mainfrom
akpatnam25:fix-client-side-logging
Closed

[CELEBORN-2162] Supress client side connection error logging#3491
akpatnam25 wants to merge 4 commits into
apache:mainfrom
akpatnam25:fix-client-side-logging

Conversation

@akpatnam25

@akpatnam25 akpatnam25 commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Remove some client side connection errors logging that are noisy.

Why are the changes needed?

see above -- removing noise.

Does this PR introduce any user-facing change?

yes, removing noisy logs

How was this patch tested?

ran an app and validated the changes:

25/07/23 00:14:08 INFO  RegistrationClientBootstrap: authentication initiation started for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: authentication initiation successful for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: Sending SASL message for client authentication
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: client authenticated for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  TransportClientFactory: Attempted to register with a Master that is not the leader after 73.1 ms: Suggested leader is host3:9097
25/07/23 00:14:08 WARN  MasterClient: Connect to host1:9097 failed.
25/07/23 00:14:08 WARN  MasterClient: Connect to host2:9097 failed.
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: authentication initiation started for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: authentication initiation successful for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: Sending SASL message for client authentication
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: client authenticated for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  RegistrationClientBootstrap: Registration for application_1753182825631_17439_1
25/07/23 00:14:08 INFO  MasterClient: connect to master host3:9097.
25/07/23 00:14:08 INFO  MasterClient: connect to master host3:9097.

@akpatnam25
akpatnam25 marked this pull request as ready for review September 26, 2025 20:47
@akpatnam25

akpatnam25 commented Sep 26, 2025

Copy link
Copy Markdown
Contributor Author

+CC @mridulm @FMX @SteNicholas PTAL, thanks.

mridulm
mridulm approved these changes Oct 7, 2025
View reviewed changes

@mridulm mridulm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mridulm

mridulm commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

I plan to merge this later this week. +CC @SteNicholas as you reviewed it as well. Thx !

@SteNicholas

SteNicholas commented Oct 9, 2025

Copy link
Copy Markdown
Member

@akpatnam25, thanks for update. @mridulm, I have merged into main(v0.7.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mridulm mridulm mridulm approved these changes
@SteNicholas SteNicholas SteNicholas approved these changes

Assignees

No one assigned

Labels

module:common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akpatnam25 @mridulm @SteNicholas