Repository navigation
Conversation
…eborn tab Move "Celeborn Build Information" and "Celeborn Properties" to the top of the Celeborn tab (above "Shuffle Assignments" and "Worker Slots"), collapse all sections by default, and unify section naming by dropping "Client" from the build info title.
Contributor
|
Merge Summary:
Posted by |
Contributor
|
Thanks @yew1eb for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
The build info and properties sections are the ones users check most often (client version, commit, effective
spark.celeborn.*configs), but they render at the bottom of the page and "Celeborn Properties" is expanded by default, pushing the summary and other sections away. Moving them to the top with all sections collapsed by default makes the page scannable, and the naming becomes consistent between the two sections.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
Manually verified on a local docker-compose cluster (Celeborn master + 3 workers + Spark 3.5.9 standalone) with a
reduceByKeyshuffle job kept alive viaspark-shell. The rendered/celeborn/page shows the four sections in the new order, all witharrow-closedand thecollapsedclass, and both the build info table (version / commit / revision) and the properties table populated.