Skip to content

Fix extnesible SMGR API violation in ao_truncate replay #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reshke wants to merge 2 commits into
base: REL_2_STABLE
Choose a base branch
from
+8 −4
Open

Fix extnesible SMGR API violation in ao_truncate replay #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2356093
Fix extnesible SMGR API violation in ao_truncate replay
reshke Aug 25, 2026
98565c8
Fix same issue with vacuum progress reporting; also close fd after use
reshke Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/backend/access/appendonly/aomd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,9 +714,12 @@ ao_segfile_get_physical_size(Relation aorel, int segno, FileNumber filenum)
filenum,
segno,
fileSegNo);
fd = PathNameOpenFile(filenamepath, O_RDONLY | PG_BINARY);
fd = aorel->rd_smgr->smgr_ao->smgr_AORelOpenSegFile(RelationGetRelid(aorel), filenamepath, O_RDONLY | PG_BINARY);
if (fd >= 0)
physical_size = FileDiskSize(fd);
{
physical_size = aorel->rd_smgr->smgr_ao->smgr_FileDiskSize(fd);
aorel->rd_smgr->smgr_ao->smgr_FileClose(fd);
}
else
elogif(Debug_appendonly_print_compaction, LOG,
"No gp_relation_node entry for append-optimized relation \"%s\", relation id %u, relfilenode %u filenum #%d, logical segment #%d (physical segment file #%d)",
Expand All @@ -726,5 +729,6 @@ ao_segfile_get_physical_size(Relation aorel, int segno, FileNumber filenum)
filenum,
segno,
fileSegNo);

return physical_size;
}
4 changes: 2 additions & 2 deletions src/backend/cdb/cdbappendonlyxlog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,15 +177,15 @@ ao_truncate_replay(XLogReaderState *record)
return;
}

if (FileTruncate(file, xlrec->target.offset, WAIT_EVENT_DATA_FILE_TRUNCATE) != 0)
if (smgr->smgr_ao->smgr_FileTruncate(file, xlrec->target.offset, WAIT_EVENT_DATA_FILE_TRUNCATE) != 0)
{
ereport(WARNING,
(errcode_for_file_access(),
errmsg("failed to truncate file \"%s\" to offset:" INT64_FORMAT " : %m",
path, xlrec->target.offset)));
}

FileClose(file);
smgr->smgr_ao->smgr_FileClose(file);
}

void
Expand Down
Loading