Skip to content

Download SerDe snapshots from datasketches-tck - #753

Merged
leerho merged 3 commits into
mainfrom
codex/download-tck-snapshots
Aug 13, 2026
Merged

Download SerDe snapshots from datasketches-tck#753
leerho merged 3 commits into
mainfrom
codex/download-tck-snapshots

Conversation

@tisonkun

@tisonkun tisonkun commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the C++ checkout, build, and snapshot generation steps with downloads from a pinned apache/datasketches-tck revision
  • run the existing C++ and Go SerDe regression profiles as separate workflow matrix jobs
  • add a reusable Bash downloader that extracts only the requested language snapshots and replaces stale local test data
  • rename the workflow file from cpp-serde-compat.yml to serde-compat.yml now that it covers both languages

The pinned TCK revision matches the one currently used by datasketches-rust. datasketches-java does have a Go regression profile; it currently covers the CPC cross-language case, so this PR enables it in CI with TCK snapshots as well.

Testing

  • tools/download_serialization_test_data.sh (223 C++ snapshots and 251 Go snapshots)
  • mvn test -P check-cpp-files (38 tests)
  • mvn test -P check-go-files (1 test)
  • mvn test (2,279 tests)
  • mvn verify -DskipTests
  • Bash syntax, workflow YAML, and git diff checks

@tisonkun
tisonkun marked this pull request as ready for review August 13, 2026 15:08
@tisonkun
tisonkun requested a review from leerho August 13, 2026 15:44
@leerho
leerho merged commit d5cce9b into main Aug 13, 2026
8 checks passed
@leerho
leerho deleted the codex/download-tck-snapshots branch August 13, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants