Repository navigation
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Restore the chart host's original ARIA attributes when generated labels are disabled, while preserving attributes changed by the application.
Fixed issues
Fixes #21803.
Details
Before: What was the problem?
After generating a label,
aria.enabled: false,aria.label.enabled: false, orsetOption({}, { notMerge: true })leaves the generatedrole="img"and stalearia-labelon the chart host.After: How does it behave after the fixing?
Track the original and last generated values on the host DOM element. On disable, restore or remove only attributes whose values still match the generated values. Keeping this state on the DOM also handles
notMerge; application changes are preserved independently for each attribute. Re-enabling produces the current label again.The existing ARIA unit file now covers all three disable paths, automatic descriptions, pre-existing host attributes, application overrides, repeated updates, and re-enabling.
Document Info
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
npm test -- --runInBand --runTestsByPath test/ut/spec/series/aria-columns-exclude.test.ts --coverage=false: 12 passed; before the fix, 8 failed and 4 passed.npm test -- --runInBand: all 26 suites / 204 tests passed with the default coverage setting.npx eslint src/visual/aria.tsandnpm run checkheader: passed.npm run lint: the same 6 pre-existing BMap diagnostics on unchanged HEAD and this patch.npm run checktype: blocked by 1,364 parser diagnostics in the installed@types/nodedeclarations under the repository's TypeScript 4.4.3; diagnostics are identical on unchanged HEAD and this patch. No dependency changes are included. Supplemental source checks excluding ambient types produce the same existing 23 browser-source and 30 BMap diagnostics on base and patch, with no new ARIA diagnostic; these are not claimed as passing typechecks.Merging options
Other information
Implementation and regression tests were prepared with AI assistance and verified locally. No generated bundles are included.