Repository navigation
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI disclosure
Codex Astra High implemented and tested this PR and drafted the description. Claude Opus 5.5 High reviewed the changes. I set the requirements, checked the playground, and approved publication.
Codex was asked to:
Claude reported bugs and proposed simplifications. Codex checked the findings with reproductions and tests before applying the changes. It also added tests for shared timing callbacks with reordered categories and for removed series whose indices were reused.
Brief Information
This pull request is in the type of:
What does this PR do?
Keeps Cartesian stacked bars connected during entrance animations and interrupted legend transitions.
Interactive playground compares upstream, #20862, and this fix across 16 cases.
Fixed issues
Fixes #19095. Supersedes #20862 by @Enigmatrix.
Details
Before: What was the problem?
Segments grow at their final positions, leaving gaps during entrance. Hiding a middle series removes it before its neighbors finish moving. Showing it again before the animation ends can cause a jump.
After: How does it behave after the fixing?
Segments with matching entrance timing grow from a shared baseline. Hidden bars shrink as their neighbors move. Rapid toggles reverse the animation from the current shape.
Hidden stacked views keep their last rendered data so they can be restored. This keeps the data in memory while the series is hidden.
Different animation timings can still produce gaps.
barMinHeightlayout is unchanged. The playground includes both cases.Document Info
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/bar-cartesian-stack-anim.htmltest/ut/spec/series/barAnimation.test.tsAll 284 unit tests pass, including 90 bar animation tests. Type checks and ESLint pass. Browser checks covered 32 playground combinations across Canvas and SVG.
Merging options
Other information
N.A.