Repository navigation
test: assert expected exceptions in 5 core tests - #8323
Open
sharanggupta wants to merge 2 commits into
Open
sharanggupta wants to merge 2 commits into
sharanggupta wants to merge 2 commits into
Conversation
Five tests in MessageFutureTest, ChannelManagerTest and DefaultServerMessageListenerImplTest checked the exception only in a catch block, so they passed when nothing was thrown.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #8323 +/- ##
============================================
+ Coverage 79.84% 79.90% +0.06%
+ Complexity 1162 1160 -2
============================================
Files 1400 1400
Lines 53011 53011
Branches 6349 6349
============================================
+ Hits 42325 42358 +33
+ Misses 7729 7706 -23
+ Partials 2957 2947 -10 see 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Five tests in
MessageFutureTest,ChannelManagerTestandDefaultServerMessageListenerImplTestchecked the exception only in a catch block, so they passed when nothing was thrown. They now useassertThrowsand then check the message.Ⅱ. Does this pull request fix one issue?
No.
Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR fixes existing tests.
Ⅳ. Describe how to verify it
./mvnw -pl core -am test -Dtest=MessageFutureTest,ChannelManagerTest,DefaultServerMessageListenerImplTest -Dsurefire.failIfNoSpecifiedTests=falsepasses (71 tests). IfMessageFuture.get,ChannelManager.getChannelorgetServerMessageSenderstop throwing, the old tests still pass and the new ones fail.