-
Notifications
You must be signed in to change notification settings - Fork 8
Replace Maven Cache with Mimír #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -227,6 +227,7 @@ | |
| <jacoco-maven-plugin.version>0.8.13</jacoco-maven-plugin.version> | ||
| <log4j-changelog-maven-plugin.version>0.9.0</log4j-changelog-maven-plugin.version> | ||
| <maven-artifact-plugin.version>3.6.0</maven-artifact-plugin.version> | ||
| <mimir.version>0.7.4</mimir.version> | ||
| <restrict-imports-enforcer-rule.version>2.6.1</restrict-imports-enforcer-rule.version> | ||
| <spotbugs-maven-plugin.version>4.9.3.0</spotbugs-maven-plugin.version> | ||
| <spotless-maven-plugin.version>2.44.4</spotless-maven-plugin.version> | ||
|
|
@@ -362,6 +363,12 @@ | |
| <version>${maven-artifact-plugin.version}</version> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
|
ppkarwasz marked this conversation as resolved.
|
||
| <groupId>eu.maveniverse.maven.mimir</groupId> | ||
| <artifactId>extension</artifactId> | ||
| <version>${mimir.version}</version> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-maven-plugin</artifactId> | ||
|
|
@@ -956,6 +963,16 @@ | |
| </executions> | ||
| </plugin> | ||
|
|
||
| <!-- | ||
| ~ Use Mimir as Maven cache: | ||
| ~ See: https://maveniverse.eu/docs/mimir/ | ||
| --> | ||
| <plugin> | ||
| <groupId>eu.maveniverse.maven.mimir</groupId> | ||
| <artifactId>extension</artifactId> | ||
| <extensions>true</extensions> | ||
| </plugin> | ||
|
Comment on lines
+970
to
+974
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this mean Mimir will be used everywhere, not just CI?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, if we add it as an extension, it will be used everywhere. There are three ways to use Mimír:
I don't see any disadvantage in using it for all users, do you? The local Maven repository still exists and you can still put staging artifacts there, but Mimír uses a second level cache with only Maven Central artifacts inside. |
||
|
|
||
| </plugins> | ||
|
|
||
| </build> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xmlns="https://logging.apache.org/xml/ns" | ||
| xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd" | ||
| type="added"> | ||
| <issue id="389" link="https://github.com/apache/logging-parent/pull/389"/> | ||
| <description format="asciidoc">Use Mimír instead of Maven local repository cache.</description> | ||
| </entry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where/How do we evict out-of-date cache entries?