Construct ClassIndex based on the CompilationInfo, to correctly reflect the available modules/classes. - #9543
Draft
lahodaj wants to merge 1 commit into
Draft
Construct ClassIndex based on the CompilationInfo, to correctly reflect the available modules/classes.#9543lahodaj wants to merge 1 commit into
lahodaj wants to merge 1 commit into
Conversation
…ct the available modules/classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at Jaroslav's report:
https://lists.apache.org/thread/f5st2t0wspbdmjt6v5ojobzqpl7cjk9n
There's a general problem with
ClassIndex- it is based onClasspathInfoonly, and only on boot, compile and source path. This means theClassIndexdoes not see things on the module path, and module classpath(*).ComputeImportshas a hack to workaround this, but code completion does not.I think it is time to bite the bullet, at least partially, and try to fix this more conceptually.
The proposal herein is that we'll take
ClassIndexfromCompilationInfos, notClasspathInfos, wherever possible, and that thisClassIndexwill be configured based on the actual modules in the compilation.(*) I am not quite certain we need module classpath (basically, classpath, but when modules are enabled). I think it would make more sense to only have classpath, but lets not dive into that too deep in this PR.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)