Skip to content

[format] Fix Parquet delta length reads across vector batches #9366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

[format] Fix Parquet delta length reads across vector batches #9366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...in/java/org/apache/paimon/format/parquet/reader/VectorizedDeltaLengthByteArrayReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public void readBinary(int total, WritableBytesVector c, int rowId) {
ByteBufferOutputWriter outputWriter = ByteBufferOutputWriter::writeArrayByteBuffer;
int length;
for (int i = 0; i < total; i++) {
length = lengthsVector.getInt(rowId + i);
length = lengthsVector.getInt(currentRow + i);
try {
buffer = in.slice(length);
} catch (EOFException e) {
Expand Down
16 changes: 16 additions & 0 deletions ...c/test/java/org/apache/paimon/format/parquet/reader/DeltaLengthByteArrayEncodingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,22 @@ public void testSerialization() throws Exception {
readAndValidate(reader, writer.getBytes().toInputStream(), values.length, values);
}

@Test
public void testReadOnePageAcrossVectorBatches() throws Exception {
String[] values = {"a", "bbbb", "ccccc"};
writeData(writer, values);
reader.initFromPage(values.length, writer.getBytes().toInputStream());
HeapBytesVector vector = new HeapBytesVector(values.length);

reader.readBinary(1, vector, 0);
assertArrayEquals(values[0].getBytes(), vector.getBytes(0).getBytes());

vector.reset();
reader.readBinary(2, vector, 0);
assertArrayEquals(values[1].getBytes(), vector.getBytes(0).getBytes());
assertArrayEquals(values[2].getBytes(), vector.getBytes(1).getBytes());
}

@Test
public void testRandomStrings() throws Exception {
String[] values = Utils.getRandomStringSamples(1000, 32);
Expand Down
Loading