SOLR-16458: Add node threads JAX-RS API - #4722
Conversation
| @JsonProperty("threadCount") | ||
| public Map<String, Object> threadCount; | ||
|
|
||
| @JsonProperty("deadlocks") |
There was a problem hiding this comment.
i think, in a perfect, world, these Object would be more strongly typed, but I don't have a great sense of how complex that owuld be!
There was a problem hiding this comment.
I agree that strongly typed response fields would be preferable. I’ll look at the existing response models and update this to use appropriate typed classes where practical.
| } | ||
|
|
||
| @Override | ||
| public Boolean registerV2() { |
There was a problem hiding this comment.
i am not totally positive, so need to look at other exampels, but maybe this registerV2 goes away, since this sithe v1 way? i thought the registerV2 was basically a way you could have a v1 api particpiate in the old v2 way... not posivite
There was a problem hiding this comment.
I’ll check the existing JAX-RS API implementations and verify whether registerV2() is still required here. I’ll update this accordingly.
|
@epugh
The updates are pushed in the latest commit. |
2 participants
Description
This PR adds a JAX-RS API for retrieving thread dump information from the receiving Solr node.
The existing
ThreadDumpHandlerfunctionality is exposed through the new JAX-RS endpoint while preserving the existing thread dump response structure and information.Changes
NodeThreadsApiendpoint for/node/threads.NodeThreadsResponsemodel for the JAX-RS response.ThreadDumpHandlerto expose the JAX-RS API.Testing
:solr:core:compileJava— passed:solr:core:test --tests org.apache.solr.handler.admin.ThreadDumpHandlerTest— passed (4 tests, 2 skipped)Issue
SOLR-16458