Repository navigation
Conversation
5b8bd98 to
e602837
Compare
|
I checked this on top of current With the two |
e602837 to
506d79c
Compare
|
Updated in The branch is now rebased onto Local verification completed:
A fresh upstream CI run is starting for the rebased revision. Your confirmation that both focused tests pass and that the regression test fails without the C++ change verifies that the test still exercises the intended bug. |
wwoosshh
left a comment
There was a problem hiding this comment.
Thanks for the update. I re-checked 506d79cd2 on top of main (d55759e): both tests in tests/python/relax/test_transform_allocate_workspace.py pass, test_nested_global_function_is_well_formed fails when allocate_workspace.cc is reverted to main, and pre-commit passes on the changed files.
LGTM.
Why
AllocateWorkspaceskips rewritingCodegenandCompositefunction bodies, but it could still rename and remove workspace-bearing global functions referenced by those bodies. This left the skipped callers with danglingGlobalVarreferences.What
Codegen/Compositefunctions.main -> Codegen -> global Composite.Fixes #20479
Testing
python -m pytest tests/python/relax/test_transform_allocate_workspace.py -q(2 passed)python tests/lint/check_file_type.pygit diff --check