Fix referencing WASILibc.stdout/stderr in Swift 6.5+ - #507
Merged
Merged
Conversation
czechboy0
added
semver/none
Enabling nightly-next for Wasm doesn't work at the moment: https://github.com/apple/swift-log/actions/runs/34211697148/job/102013997187?pr=507#step:6:241 This reverts commit 946baaf.
Contributor
Author
|
Oh confirmed it fixes the Wasm issue: https://github.com/apple/swift-log/actions/runs/34212263199/job/102015794822?pr=507 |
Contributor
Author
|
The Android failure is pre-existing and also happens on main. I'm looking into that separately. |
czechboy0
enabled auto-merge (squash)
September 8, 2026 09:56
kukushechkin
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Nightly CI on nightly-main toolchains started failing on August 11, when we started downloading swift-DEVELOPMENT-SNAPSHOT-2026-08-08 instead of swift-DEVELOPMENT-SNAPSHOT-2026-07-11.
Appears to be fallout from swiftlang/swift@73fee33 improving the optionality and concurrency of stdout/stderr/stdin on the various platforms.
Modifications:
Adapted Swift Log code to handle both the existing and behavior, guarded by a
compiler(>=6.5)Also enabled nightly-next, which tracks the pre-release 6.4 right now, but hasn't received this change.
Result:
Passing CI, hopefully :)