Remove invalid exclude statements from testTarget - #514
Merged
Merged
Conversation
kukushechkin
approved these changes
Sep 16, 2026
kukushechkin
left a comment
kukushechkin
left a comment
Contributor
There was a problem hiding this comment.
@mitras-git great, thank you for fixing this!
kukushechkin
enabled auto-merge (squash)
September 16, 2026 17:37
Contributor
|
@mitras-git ah, some formatting is necessary, check the CI: https://github.com/apple/swift-log/actions/runs/35123590271/job/104906093780?pr=514 |
auto-merge was automatically disabled
September 17, 2026 15:44
Head branch was pushed to by a user without write access
kukushechkin
enabled auto-merge (squash)
September 17, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the stale exclude statements from
Package.swiftandPackage@swift-6.1.swiftMotivation:
In #485, CMake build support was added, as part of it, 99c554b added
exclude: ["CMakeLists.txt"]to all four SwiftPM targets, including tests, but the CI was revealing some issues with CMake test-targets. So after review, in 4a81108 the CMake build files were removed from the/Testsdirectory but I accidentally left behind the exclusions in the package manifests.Modifications:
Removed the exclude statements from Package.swift and Package@swift-6.1.swift.
Result:
No SwiftPM errors!
Fixes: #513