Repository navigation
Fix reader hanging on PDFs with no extractable content - #41
Merged
Merged
Conversation
When background ingestion finishes without producing any readable chapter (e.g. a scanned/image-only PDF with no usable OCR text), the reader was left spinning on "Loading book..." indefinitely with no error, since errors from processChaptersInBackground were silently swallowed. Now it surfaces a clear error state instead.
PDFs are ingested as a single chapter, so a legitimate table of contents near the start could trip the TOC heuristic and exclude the whole document, not just the TOC. Only fully exclude a chapter as TOC when it's actually TOC-sized; also bound the TOC scan window so unrelated numbered lists deep in a large document can't accumulate false-positive matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npx tsc --noEmit