Skip to content

fix: order uniq list aggregates by their cast field #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcapel wants to merge 1 commit into from
Closed

fix: order uniq list aggregates by their cast field #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/aggregate/lateral.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2131,6 +2131,18 @@ defmodule AshSql.Aggregate.Lateral do
:return
)

# `DISTINCT` needs each `ORDER BY` to match the aggregated expression exactly,
# including its cast, so order by `field` itself rather than the bare column.
sort_expr =
if Map.get(aggregate, :uniq?) && !dedupe_sorted? do
sort
|> AshSql.Sort.sanitize_sort()
|> Enum.map(fn {order, _} -> {order, field} end)
|> AshSql.Sort.order_to_fragments()
else
sort_expr
end

question_marks = Enum.map(sort_expr, fn _ -> " ? " end)

distinct =
Expand Down
Loading