Repository navigation
[ty] Preserve recursive structure in Annotated values - #29058
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportMemory usage unchanged ✅ |
|
Merging this PR will not alter performance
Comparing Footnotes
|
charliermarsh
force-pushed
the
charlie/ty-3837-investigation
branch
from
October 1, 2026 23:45
3b91fb0 to
13f1ee1
Compare
charliermarsh
marked this pull request as ready for review
October 1, 2026 23:52
charliermarsh
force-pushed
the
charlie/ty-3837-investigation
branch
from
October 2, 2026 20:05
13f1ee1 to
1393070
Compare
charliermarsh
force-pushed
the
charlie/ty-3837-investigation
branch
from
October 5, 2026 14:42
1393070 to
f46fb5b
Compare
charliermarsh
force-pushed
the
charlie/ty-3837-investigation
branch
from
October 7, 2026 02:00
f46fb5b to
df83095
Compare
dhruvmanila
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We now terminate inference when an
Annotatedvalue recursively wraps its own inferred type:We preserve the
Annotatedwrapper when simplifying the recursive type, so inference can recognize the cycle and stop expanding it.Addresses the runtime
Annotatedreproducer in astral-sh/ty#3837.