Repository navigation
[ty] Validate Generic and Protocol arguments directly - #29146
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
added
bug
charliermarsh
added this pull request to stack #29150
October 6, 2026 20:05
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportMemory usage unchanged ✅ |
|
charliermarsh
marked this pull request as ready for review
October 6, 2026 20:36
charliermarsh
removed this pull request from stack #29150
October 6, 2026 23:50
charliermarsh
added this pull request to stack #29156
October 6, 2026 23:50
Reject instance arguments even when their members or type arguments contain TypeVarTuple objects. Avoid searching those members, which can recurse through changing specializations. Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
charliermarsh
force-pushed
the
charlie/codex-generic-base-validation
branch
from
October 7, 2026 02:00
79eaa65 to
09950dc
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We validate the arguments to
Generic[...]andProtocol[...]directly. An invalid argument can contain aTypeVarTuplein one of its members, but that does not make it a valid type parameter. We now report the invalid argument instead of treating it as an unsupported variadic form.This also avoids expanding unrelated members and recursive bounds while validating a class's generic parameters.