Repository navigation
[ty] Promote tuple lengths based on the outer element types - #29147
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
added this pull request to stack #29150
October 6, 2026 20:05
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdowntrio
prefect
sphinx
|
|
charliermarsh
marked this pull request as ready for review
October 6, 2026 20:56
charliermarsh
removed this pull request from stack #29150
October 6, 2026 23:50
charliermarsh
added this pull request to stack #29156
October 6, 2026 23:50
Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
charliermarsh
force-pushed
the
charlie/codex-tuple-promotion
branch
from
October 7, 2026 02:00
7afcfde to
9c77300
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We normally infer
list[tuple[int, ...]]for[(1,), (1, 2)], allowing tuples of other lengths to be added later. This tuple-size promotion applies to tuple literals; tuple types supplied by annotations or other expressions retain their existing lengths.The check that preserves those lengths currently searches for tuples anywhere inside an element's type. This incorrectly blocks promotion when the tuple appears inside a generic type argument, a callable's return type, or a protocol member:
The
Boxis not a tuple, so its type argument should not prevent us from widening the two tuple literals. We replace this use ofany_over_typewith a check for whether the element itself may be a tuple. The check still follows aliases, unions, type-variable bounds, andNewTypebases that can describe a tuple value, while skipping nested type arguments and members.