Repository navigation
[ty] Preserve checks for recursive descriptor setter types - #29148
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
added this pull request to stack #29150
October 6, 2026 20:05
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportMemory usage unchanged ✅ |
|
| Project | Old Time | New Time | Change |
|---|---|---|---|
django-test-migrations |
0.10s | 0.05s | -53% |
Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.
charliermarsh
marked this pull request as ready for review
October 6, 2026 20:57
charliermarsh
removed this pull request from stack #29150
October 6, 2026 23:50
charliermarsh
added this pull request to stack #29156
October 6, 2026 23:50
Inspect dependencies on the setter signature explicitly, including recursive aliases, protocols, and TypedDicts. Recursive specializations that are independent of the setter parameters retain their writable-member checks. Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
charliermarsh
force-pushed
the
charlie/codex-descriptor-dependencies
branch
from
October 7, 2026 02:00
edcaf05 to
e55268b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a stack overflow when checking a protocol's writable member whose descriptor setter accepts a recursive type. For example, checking the assignment below previously aborted the process instead of reporting an invalid assignment:
The setter's unused
Utriggers a search to determine whether the accepted value type depends on that type parameter. The existing search followsnextthroughRecursive[int],Recursive[list[int]],Recursive[list[list[int]]], and so on. Its recursion guard remembers exact types, so these changing specializations never repeat and the search overflows the stack. RemovingUavoids the search and the crash.We replace that general type search with a dependency check that recognizes repeated definitions and inspects the arguments of recursive references without repeatedly expanding their bodies. Here, it establishes that the setter accepts
Recursive[int]independently ofU, so we can report the invalid assignment normally. The same fix covers recursiveTypedDicts and type aliases, while retaining checks for assignments and protocol compatibility.