Repository navigation
[ty] Simplify mapped intersections through aliases - #29154
Closed
charliermarsh wants to merge 1 commit into
Closed
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
added this pull request to stack #29153
October 6, 2026 23:40
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportMemory usage unchanged ✅ |
|
Merging this PR will degrade performance by 7.58%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
charliermarsh
removed this pull request from stack #29153
October 7, 2026 00:09
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #29152.
We now simplify mapped intersections through aliases without expanding the alias unless a simplification changes the result. For example:
Previously, we revealed
Boolean & ~Literal[True]. The alias was retained to avoid unfolding recursive types, but that hid the boolean from the normal simplification rule.Intersection construction still expands unions, nested intersections, and enum complements so it can distribute and flatten them. The inner builder now inspects the underlying types when applying simplification rules, including truthiness, enum exclusions, constrained type variables, and gradual generics. Unchanged aliases retain their identity. This removes the separate lists of positive and negated alias shapes that could be preserved.