Repository navigation
[ty] Make lazy type traversal explicit - #29155
Open
charliermarsh wants to merge 2 commits into
Open
charliermarsh wants to merge 2 commits into
charliermarsh wants to merge 2 commits into
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
charliermarsh
added this pull request to stack #29156
October 6, 2026 23:50
Memory usage reportMemory usage unchanged ✅ |
|
Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
charliermarsh
force-pushed
the
charlie/codex-explicit-type-visitors
branch
from
October 7, 2026 02:00
bdc926b to
e4d8601
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All remaining callers of
any_over_typeandfind_over_typeuse the oldfalsebehavior: walk stored nested types without evaluating lazy attributes. The flag no longer varies between callers, so we remove it and make that traversal the fixed behavior of both helpers.Analyses that need lazy attributes now choose them explicitly. Visitors override the methods for the types they need to expand; for example, the recursion check explicitly visits alias values, protocol members,
TypedDictfields, type-variable attributes, andNewTypebases. Specialized alias searches can still compose the general helper:any_over_type_expanding_aliasesuses it to walk stored types and explicitly recurses into alias values.This preserves existing traversal behavior while removing the visitor-wide lazy-attribute switch and the shared search modes.