Remove the Epoch From Simplex Epoch Info - #587
Merged
Merged
Conversation
yacovm
reviewed
Sep 9, 2026
| } | ||
| if other == nil { | ||
| return ei == nil | ||
| return false |
Collaborator
Author
There was a problem hiding this comment.
because ei can never be nil here
yacovm
reviewed
Sep 9, 2026
| // It is set to the hash of the zero block in the first epoch, and in subsequent epochs it is set to be | ||
| // the hash of the sealing block of the previous epoch. | ||
| // This is used to be able to quickly fetch and verify the sealing blocks without having to retrieve the interleaving blocks, | ||
| // which allows to bootstrap the BLS keys of the validator set for each epoch before fully syncing the interleaving blocks. |
Collaborator
There was a problem hiding this comment.
we should decrement all field numbers by 1
yacovm
previously approved these changes
Sep 9, 2026
Collaborator
|
LGTM otherwise |
yacovm
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value should always be the same as the value in the protocol metadata, so there is no point in having a duplicate field