Conversation
yacovm
reviewed
Sep 13, 2026
| } | ||
|
|
||
| return nil | ||
| // The current finalization in incompleteSequences belongs to a Telock |
Collaborator
There was a problem hiding this comment.
can we add an explicit check that:
bh.Epoch > stored.Epoch ?
yacovm
reviewed
Sep 13, 2026
| zap.Stringer("From", from), | ||
| ) | ||
|
|
||
| incomplete.block = nil |
Collaborator
There was a problem hiding this comment.
shouldn't we have an epoch comparison check? Only nil if the block's epoch is lower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-validator is not aware of Telocks. It only knows about the
VerifiedBlock&Blockapis defined incommonpackage. The non-validator was running of the assumption that the same sequence could not have two different finalizations. It would halt the non-validator as a defensive check if it ever noticed that.This PR ensures that the non-validator does not halt the chain if the two finalizations are different and one of them is a telock. Instead, it drops the telock and requests the actual finalization which will always be for the higher epoch.
Closes #545