fix(event-handler): fail invocation on UnauthorizedException in onPublish - #5621
Open
svozza wants to merge 3 commits into
Open
fix(event-handler): fail invocation on UnauthorizedException in onPublish#5621svozza wants to merge 3 commits into
svozza wants to merge 3 commits into
Conversation
…ggregate onPublish handlers Closes #5620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnauthorizedExceptionthrown from a non-aggregateonPublishhandler was caught per event and returned as an{ id, error }entry, so the invocation completed successfully. The documented behaviour, and the existing behaviour for aggregateonPublishandonSubscribehandlers, is for the invocation to fail. This change aligns the non-aggregate path with the other two.Changes
AppSyncEventsResolver.handleOnPublishrethrowsUnauthorizedExceptioninside the per-event catch before formatting the error response, matching the aggregate and subscribe pathsRouter.onPublishJSDoc notes thatUnauthorizedExceptionis the exception to the per-event error handlingonPublishhandler that throwsUnauthorizedExceptionfor one of two events, asserting the invocation rejectsIssue number: closes #5620
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.