Repository navigation
Fix leaderboard filters overflow on iPhone - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
profile.htmlCSS to extend the@media (max-width:650px)rule with.tabs{display:grid;grid-template-columns:repeat(2,minmax(0,1fr))}and.tabs button{min-width:0;padding-inline:8px;font-size:13px}to create a two-column compact layout for the game filters.tests/profile-page.test.jsasserting the new responsive CSS selectors are present inprofile.html.Testing
node --test tests/profile-page.test.jsand the new responsive test passed.npm run check(type checks vianode --check) and they completed successfully.npm testrun showed the new test failed before the fix, and after the change the focused profile tests passed; the suite check passed after fixing the CSS.Codex Task