Skip to content

main fails Lint & Format: 9292c2c stripped trailing newlines from 9 files #84

Closed

Description

@chaksaray

Problem

CI on main has been red since 9292c2c ("fix: conflict on the version"). The Lint & Format job fails on black:

would reformat scanner/core/fp_pipeline.py
would reformat scanner/scanner.py

The commit removed the final newline from 9 files. The diff shows each line as unchanged because only the newline at end of file was lost, which is typical of resolving a conflict in the GitHub web editor:

Dockerfile
README.md
docker-compose.yml
docs/guides/evidence-lifecycle.md
pyproject.toml
scanner/core/fp_pipeline.py
scanner/scanner.py
tests/unit/test_finding_evidence_metadata.py
tests/unit/test_output_contracts.py

Black only checks scanner/, so two of them fail CI. Every open PR inherits the failure (#80, #82), and so will every PR in the runbook.

Reproduce

for f in $(git show --name-only --format= 9292c2c); do
  [ -n "$(git show main:$f | tail -c1)" ] && echo "no EOF newline: $f"
done
black --check --line-length 100 scanner/

Acceptance

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions