This repository was archived by the owner on Sep 29, 2025. It is now read-only.
Repository navigation
Add user list with IPs using array and print_wrap - #32
Merged
Merged
Conversation
gobeyondpty
force-pushed
the
pr-user-display-fix
branch
from
September 22, 2025 13:13
5a86225 to
c469f8c
Compare
bcyran
suggested changes
Sep 22, 2025
gobeyondpty
force-pushed
the
pr-user-display-fix
branch
from
September 25, 2025 00:45
c469f8c to
3b4f859
Compare
Contributor
Author
|
fixed in force-pushed commit |
Owner
|
@gobeyondpty I think you pushed much more than you intended to. Please push a single commit touching a single module. |
- Convert users variable to an array as suggested by bcyran - Add space between username and IP for better readability: username (IP) - Use print_wrap function for better formatting with multiple users - Follow shellcheck recommendations for proper array handling - Use regex to extract IP from parentheses for portability across different who output formats - Handle cases where IP might be empty (local logins) by showing just username
gobeyondpty
force-pushed
the
pr-user-display-fix
branch
from
September 25, 2025 17:30
3b4f859 to
e37e855
Compare
Contributor
Author
|
done correctly this time lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses the PR review feedback:
Implements the requested changes from PR #30 review to ensure consistency with how the services module handles arrays.
🤖 Generated with Claude Code