Repository navigation
chore: remove the release-changesets reusable workflow - #42
Merged
Merged
Conversation
benhigham/javascript was its only caller and now runs its release inline (benhigham/javascript#172), on changesets/action v2 sub-actions with per-job least-privilege permissions. Changesets CLI v3 and pnpm 12 need action versions this workflow pinned below, so it would have to be rewritten anyway. Drop it and the docs that describe it as available: the README usage section, the AGENTS.md tree entry, and the workflow-scaffold skill's example. AGENTS.md's purpose list now names the composite actions, which other repos do use. The conventions for writing reusable workflows stay.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The PR description’s change list omits the mise.lock update (including the new jq entry), so the intent/scope should be clarified or the lockfile change reverted if incidental.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: None
What changed in this PR
Removes the no-longer-used release-changesets reusable workflow from this central .github repo and updates documentation/guidance to focus on composite actions as the shared automation mechanism.
Changes:
- Delete the reusable workflow
.github/workflows/release-changesets.yml. - Update repository docs (
README.md,AGENTS.md) and theworkflow-scaffoldSkill to remove references to the deleted workflow. - Update
mise.lockto include a pinnedjqtool entry (viamise lockoutput).
| File | Description |
|---|---|
| README.md | Removes the “Reusable Workflows” section and positions the repo as providing shared composite actions. |
| mise.lock | Adds a jq lock entry alongside other mise-managed tools. |
| AGENTS.md | Updates repo purpose and the tree listing to remove the deleted reusable workflow. |
| .github/workflows/release-changesets.yml | Deletes the reusable Changesets-based release workflow. |
| .claude/skills/workflow-scaffold/SKILL.md | Removes the “real example” reference to the deleted workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benhigham/javascriptwas the only caller ofrelease-changesets.yml(checked every active repo's workflows;webuses only thesetup-node-pnpmcomposite action). It now runs its release inline (benhigham/javascript#172) on thechangesets/actionv2 sub-actions with per-job least-privilege permissions. The first run onmainversioned successfully and regenerated the release PR.The workflow couldn't be kept as-is anyway: Changesets CLI v3 requires
changesets/action@v2(renamed inputs), and pnpm 12 requirespnpm/action-setup>= 6.1.0.Changes:
.github/workflows/release-changesets.ymlworkflow-scaffoldskill: remove the example that pointed at the deleted fileGeneral conventions for writing reusable workflows (skill templates,
workflow-reviewer, AGENTS.md conventions) are unchanged, since they still apply if one is added later. The dateddocs/superpowers/plan/spec are historical and left alone.Verified: Prettier, markdownlint-cli2 and actionlint pass.