Skip to content

use_arango_id option, fix graphsink key - #565

Merged
kevinschaper merged 1 commit into
biolink:masterfrom
rogermyung:fix/arango-source-id-fidelity-upstream
Sep 16, 2026
Merged

kevinschaper merged 1 commit into
biolink:masterfrom
rogermyung:fix/arango-source-id-fidelity-upstream

Conversation

@rogermyung

Copy link
Copy Markdown
Contributor

Add a new use_arango_id option (--use-arango-id), which keeps a document's own id under document_id_property, and key edges by their ArangoDB _id so parallel edges survive the in-memory graph.

GraphSink now honours a record's key without also passing it as an attribute, which raised TypeError.

Derive node ids and edge endpoints from ArangoDB document handles under a
new use_arango_id option (--use-arango-id), keeping a document's own id
under document_id_property, and key edges by their ArangoDB _id so
parallel edges survive the in-memory graph. GraphSink now honours a
record's key without also passing it as an attribute, which raised
TypeError.

Cherry-picked from 4f5dd5b on fix/arango-source-id-fidelity, adapted to
upstream's defaults: category ["biolink:NamedThing"] and predicate
biolink:related_to rather than the collection name (fork commit 004034c).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@kevinschaper kevinschaper left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kevinschaper
kevinschaper merged commit 4281378 into biolink:master Sep 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants