[EX-135] Fix sidebar UX on small screens - #101
Merged
Merged
Conversation
This is inspired by the problem described here: saadeghi/daisyui#3122 We add a `top` value to the drawer, which is only applies when the positioning of the drawer moves from sticky to fixed (see also https://developer.mozilla.org/en-US/docs/Web/CSS/top), when it's covering the whole screen. With the navbar still visible, people can close the sidebar drawer again.
This removes an unnecessary padding which caused the content to horizontally overflow on small screens. Removing this padding makes the padding on both sides equal and centers the application.
klappradla
force-pushed
the
bug/ex-135-fix-sidebar-ux-on-small-screens
branch
from
October 2, 2025 12:42
14e8be2 to
a8e6e35
Compare
Member
Author
|
Oh wait, the bitcrowd-logo is still cut off! Back to draft. |
klappradla
marked this pull request as draft
October 2, 2025 12:55
klappradla
marked this pull request as ready for review
October 2, 2025 14:12
Member
Author
Fixed this @agatheblues But I didn't have time to look into the details of how to resize the buttons/icons. Maybe a follow up. |
ammancilla
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EX-135
This fixes the sidebar UX for small screens and positions the content centered without horizontal overflow.
Changes
Move sidebar drawer under the on small screens
The values used are inspired by the problem described here.
We add a
topvalue to the drawer, which is only applies when the positioning of the drawer moves from sticky to fixed (see also https://developer.mozilla.org/en-US/docs/Web/CSS/top), when it's covering the whole screen.With the navbar still visible, people can close the sidebar drawer again and aren't forced to click on an old chat.
Center content and make it fit the screen width
Remove an unnecessary padding which caused the content to horizontally overflow on small screens and not being centered anymore
Looks
Ideally just try out the branch locally. But here are the core visual changes as screenshots: