Skip to content

fix: refresh browser controls after clearing messages #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluegrassiot merged 2 commits into from
Oct 17, 2026
Merged

fix: refresh browser controls after clearing messages #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ad64d
fix: refresh browser controls after clearing messages
bluegrassiot Oct 17, 2026
729d7b8
test: make clear controls regression deterministic
bluegrassiot Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/MqttProbe.UI/Components/Browser/BrowserPanel.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,15 @@
protected override void OnInitialized()
{
_lastCount = MessageStoreManager.RootTopicCount;
_updateTimer = new Timer(_ =>
{
if (_disposed) return;
OnTimerTick();
}, null, 0, 1_000);
_updateTimer = CreateUpdateTimer();
}

protected virtual Timer? CreateUpdateTimer() => new Timer(_ =>
{
if (_disposed) return;
OnTimerTick();
}, null, 0, 1_000);

internal void OnTimerTick()
{
if (_disposed) return;
Expand Down Expand Up @@ -138,6 +140,7 @@
return;

await MessageStoreManager.ClearAllMessages();
_lastCount = MessageStoreManager.RootTopicCount;
Snackbar.Add("All stored messages cleared.", Severity.Success);
}

Expand Down
44 changes: 44 additions & 0 deletions tests/MqttProbe.UI.Tests/Components/Browser/BrowserPanelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,45 @@ public async Task ClearMessages_AfterClear_DisablesButtonOnNextTick()
});
}

[Test]
public async Task ClearMessages_AfterClear_WhenTrafficRestoresCount_ReenablesButtonOnNextTick()
{
var rootCount = 1;
_mockMsgStore.RootTopicCount.Returns(_ => rootCount);

_mockDialogService.ShowMessageBoxAsync(
Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(),
Arg.Any<string>(), Arg.Any<string>(), Arg.Any<DialogOptions>())
.Returns(Task.FromResult<bool?>(true));

_mockMsgStore.ClearAllMessages().Returns(Task.CompletedTask)
.AndDoes(_ => rootCount = 0);

var cut = Render<BrowserPanelWithoutUpdateTimer>();

cut.FindAll("button").First(b => b.TextContent.Contains("Clear"))
.HasAttribute("disabled").Should().BeFalse();
cut.FindAll(".mud-chip").Should().HaveCount(1);

await cut.InvokeAsync(() => cut.FindAll("button")
.First(b => b.TextContent.Contains("Clear")).Click());

cut.FindAll("button").First(b => b.TextContent.Contains("Clear"))
.HasAttribute("disabled").Should().BeTrue();
cut.FindAll(".mud-chip").Should().BeEmpty();

rootCount = 1;
cut.Instance.OnTimerTick();

cut.WaitForAssertion(() =>
{
cut.FindAll("button")
.First(b => b.TextContent.Contains("Clear"))
.HasAttribute("disabled").Should().BeFalse();
cut.FindAll(".mud-chip").Should().HaveCount(1);
});
}

[Test]
public void BrowserHint_WhenNoStoresAndNotDismissed_IsVisible()
{
Expand Down Expand Up @@ -220,4 +259,9 @@ public void MobilePicker_OpensAndCloses()

cut.Markup.Should().NotContain("topic-picker-overlay__panel");
}

private sealed class BrowserPanelWithoutUpdateTimer : BrowserPanel
{
protected override System.Threading.Timer? CreateUpdateTimer() => null;
}
}
Loading